Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Oct 16, 2025

Fix

(Required) Add a concise description of what you fixed. If this is related to an issue, add a link to it. If applicable, add screenshots, animations, or videos to help illustrate the fix.

Test

(Required) List the steps to test the behavior. For example:

  1. Go to...
  2. Tap on...
  3. See error...

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in d3adb3ef with:

Added markdown support

If the changes should not be included in release notes, add a statement to this section. For example:

These changes do not require release notes.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build
Build Number1306
VersionPR #1721
Bundle IDcom.codality.NotationalFlow.Alpha
Commitfe86f77
Installation URL030rhrjuv2al8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio force-pushed the apps-infra-meetup branch 2 times, most recently from 943c28a to 6feffb0 Compare October 17, 2025 08:10
The idea is to then move the script to the CI toolkit.
@mokagio
Copy link
Contributor Author

mokagio commented Dec 3, 2025

@copilot update the track-apple-metrics script to take the xcresult and DerivedData paths as inputs and use them when calling the commands that read from those folders. Handle input not given gracefully, but keep the code doing so compact. Don't forget to update the script caller to pass the paths so we can verify.

Additionally, make the track... script use the Buildkite agent CLI to upload the JSON artifacts instead of enumerating the paths in the pipeline.yml

Copy link

Copilot AI commented Dec 3, 2025

@mokagio I've opened a new pull request, #1725, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants